Skip to content

Conversation

@axosoft-ramint
Copy link
Contributor

@axosoft-ramint axosoft-ramint commented Jun 9, 2025

Fixes #4354

  • Modifies return output of sendRequest and callers up the chain to return (and handle) 'cancelled' when a cancellation occurs.
  • Returns without showing an error message on command-level logic when receiving 'cancelled' as output.

@axosoft-ramint axosoft-ramint requested a review from d13 June 9, 2025 23:06
@axosoft-ramint axosoft-ramint force-pushed the bugs/explain-cancelation branch from af5ddaa to b889d73 Compare June 10, 2025 15:15
@axosoft-ramint axosoft-ramint force-pushed the bugs/explain-cancelation branch from b889d73 to 3adbc48 Compare June 11, 2025 21:53
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, but otherwise LGTM!

@axosoft-ramint axosoft-ramint merged commit 02ea44d into main Jun 12, 2025
1 of 2 checks passed
@axosoft-ramint axosoft-ramint deleted the bugs/explain-cancelation branch June 12, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Explain error messaging

2 participants